tests: zero filler #3465
Merged
tests: zero filler #3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acpana
force-pushed
the
acpana/zero-filler
branch
from
ea7bb25 to
e2efda2
Compare
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/zero-filler
branch
from
e2efda2 to
9538d03
Compare
jingyih
reviewed
Jan 16, 2025
|
|
||
| case reflect.Slice: // undefined for now | ||
|
|
||
| // count := rf.randStream.Intn(10) + 1 |
There was a problem hiding this comment.
Should we silently skip slice and map fields, or should we explicitly fail? Alternatively, could we create empty slices and maps to use as the "zero value"?
There was a problem hiding this comment.
We can revisit this decision but I think ignoring more complex types for now is okay. As I wire this into the dev/ generation tools we will iterate here.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 1f51004
into
GoogleCloudPlatform:master
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a zero filler (similar to the random filler) to the KRMgen. We will use this in tooling to create tests for set 0 scenarios.